Skip to content

Reinstate prerelease upgrade warning#90093

Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom
DaveCTurner:2022-09-15-reinstate-prerelease-upgrade-warning
Sep 15, 2022
Merged

Reinstate prerelease upgrade warning#90093
elasticsearchmachine merged 4 commits intoelastic:mainfrom
DaveCTurner:2022-09-15-reinstate-prerelease-upgrade-warning

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

This warning was lost in #83489, but it's important we have it in these docs since users keep on trying this kind of invalid upgrade. This commit reinstates the lost warning.

This warning was lost in elastic#83489, but it's important we have it in these
docs since users keep on trying this kind of invalid upgrade. This
commit reinstates the lost warning.
@DaveCTurner DaveCTurner added >docs General docs changes :Core/Infra/Core Core issues without another label labels Sep 15, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 15, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v8.5.0 labels Sep 15, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this omission @DaveCTurner 🥅 I provided a suggested rendering that attempts to pull in some of the language from the note previously removed in #83489, but accounts for some of your proposed edits.

DaveCTurner and others added 3 commits September 15, 2022 15:20
Co-authored-by: Adam Locke <adam.locke@elastic.co>
@DaveCTurner
Copy link
Copy Markdown
Member Author

Thanks @lockewritesdocs - I adopted your suggestion and made a couple of minor alterations, see 1c3efad:

  • mention that the data loss may be silent
  • you should discard the contents of the cluster before any upgrade, not just when upgrading to a released version

@lockewritesdocs lockewritesdocs self-requested a review September 15, 2022 14:27
Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaveCTurner -- I'm 👍 with your changes.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 15, 2022
@elasticsearchmachine elasticsearchmachine merged commit c7da070 into elastic:main Sep 15, 2022
@DaveCTurner DaveCTurner deleted the 2022-09-15-reinstate-prerelease-upgrade-warning branch September 15, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants