Synthetic _source: ignore_malformed for ip#90038
Merged
nik9000 merged 10 commits intoelastic:mainfrom Sep 26, 2022
Merged
Conversation
This adds synthetic `_source` support for `ip` fields with `ignore_malfored` set to `true`. We save the field values in hidden stored field, just like we do for `ignore_above` keyword fields. Then we load them at load time.
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
This was referenced Sep 13, 2022
Closed
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Sep 22, 2022
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
This is great, thanks @nik9000
server/src/main/java/org/elasticsearch/index/mapper/IgnoreMalformedStoredValues.java
Outdated
Show resolved
Hide resolved
martijnvg
approved these changes
Sep 22, 2022
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - I like the fallback to stored fields incase of ignore malformed.
Member
Author
|
run elasticsearch-ci/packaging-tests-windows-sample |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds synthetic
_sourcesupport foripfields withignore_malforedset totrue. We save the field values in hidden stored field, just like we do forignore_abovekeyword fields. Then we load them at load time.