Simplify reconciliation#89900
Merged
idegtiarenko merged 35 commits intoelastic:feature/desired-balance-allocatorfrom Sep 30, 2022
Merged
Simplify reconciliation#89900idegtiarenko merged 35 commits intoelastic:feature/desired-balance-allocatorfrom
idegtiarenko merged 35 commits intoelastic:feature/desired-balance-allocatorfrom
Conversation
Contributor
Author
|
This branch has following IT failures:
|
…iliation # Conflicts: # server/src/main/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java
23 tasks
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
commented
Sep 27, 2022
| public class SingleShardNoReplicasRoutingTests extends ESAllocationTestCase { | ||
| private final Logger logger = LogManager.getLogger(SingleShardNoReplicasRoutingTests.class); | ||
|
|
||
| @AwaitsFix(bugUrl = "desired balance") |
Contributor
Author
There was a problem hiding this comment.
This seems to be the only failure on this branch
Contributor
Author
|
@elasticsearchmachine please run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticsearchmachine please run elasticsearch-ci/part-1 |
DaveCTurner
approved these changes
Sep 29, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM, I left only a few tiny nits.
...va/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/allocation/AllocationService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/allocation/AllocationService.java
Outdated
Show resolved
Hide resolved
…ion/AllocationService.java Co-authored-by: David Turner <david.turner@elastic.co>
…ion/AllocationService.java Co-authored-by: David Turner <david.turner@elastic.co>
Contributor
Author
|
@elasticsearchmachine please run elasticsearch-ci/part-1 |
Contributor
Author
|
@elasticsearchmachine please run elasticsearch-ci/part-2 |
Contributor
Author
|
@elasticsearchmachine please run elasticsearch-ci/part-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.