Add NodeIndicesStats to NodeStatsTests#89798
Merged
kingherc merged 1 commit intoelastic:mainfrom Sep 7, 2022
Merged
Conversation
bbdc707 to
4400afd
Compare
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
As discussed async, lets try to turn these classes into records instead of adding so much code for manual equals and hashCode if we can.
original-brownbear
approved these changes
Sep 7, 2022
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, it's a little unfortunate that we have to be so verbose here, but I agree that this is better and easier to maintain than what we did for other stats in the tests where we manually test all the getters. It's unfortunate records don't work for us here :)
Contributor
Author
|
I agree it's a bit unfortunate. I was excited to test records until I realized that the stats need mutations (due to their |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will lighten the load of upcoming PR of issue #86639.