Skip to content

Fix module and package names for stable plugin api#89772

Merged
pgomulka merged 1 commit intoelastic:mainfrom
pgomulka:fix_plugin_analysis_api_module_name
Sep 5, 2022
Merged

Fix module and package names for stable plugin api#89772
pgomulka merged 1 commit intoelastic:mainfrom
pgomulka:fix_plugin_analysis_api_module_name

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Sep 1, 2022

the convention for packages and module names is:
org.elasticsearch.plugin[.analysis].api

module-info.java and package-info.java were using incorrect names
and not following the convention
relates #88980

the convention for packages and module names is:
org.elasticsearch.plugin[.analysis].api

module-info.java and package-info.java were using incorrect names
and not following the convention
@pgomulka pgomulka added :Core/Infra/Plugins Plugin API and infrastructure v8.5.0 labels Sep 1, 2022
@pgomulka pgomulka self-assigned this Sep 1, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 1, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Sep 5, 2022

@elasticmachine run elasticsearch-ci/part-3

@pgomulka pgomulka merged commit 2b6d4e9 into elastic:main Sep 5, 2022
@pgomulka pgomulka mentioned this pull request Sep 5, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Plugins Plugin API and infrastructure >non-issue >refactoring Team:Core/Infra Meta label for core/infra team v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants