Synthetic _source: support version field type#89706
Merged
nik9000 merged 4 commits intoelastic:mainfrom Aug 30, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
This adds support for synthetic _source to the `version` field type. It works very similarly to `keyword` but with an extra decode step. I modified the decoder to return a `BytesRef` instead of a `String` because many of the callers seemed to be converting that string directly into bytes again. Synthetic source would have wanted to do that. As was the query infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for synthetic _source to the
versionfield type. Itworks very similarly to
keywordbut with an extra decode step.I modified the decoder to return a
BytesRefinstead of aStringbecause many of the callers seemed to be converting that string directly
into bytes again. Synthetic source would have wanted to do that. As was
the query infrastructure.