Fix ConcurrentSnapshotsIT.testMasterFailoverOnFinalizationLoop#89648
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Aug 26, 2022
original-brownbear:89625
Merged
Fix ConcurrentSnapshotsIT.testMasterFailoverOnFinalizationLoop#89648original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:89625
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:89625
Conversation
This fixes a minor bug introduced in #89572. We need to take the listeners for the snapshot out of the listeners map for the repo right away before trying to run the next repo operation like we did prior to that change. Otherwise we run the risk of a fatal exception failing all operations for the repo like a no-longer-master exception did in #89625 even though the snapshot completed successfully. closes #89625
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Exception e) { |
Contributor
Author
There was a problem hiding this comment.
We have this pattern (a future that only succeeds but never fails) in a couple of spots now. I'll try to create a follow-up to dry this up, it's quite noisy doing this manually everywhere.
Contributor
Author
|
Thanks Tanguy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a minor bug introduced in #89572. We need to take the listeners
for the snapshot out of the listeners map for the repo right away before
trying to run the next repo operation like we did prior to that change.
Otherwise we run the risk of a fatal exception failing all operations for
the repo like a no-longer-master exception did in #89625 even though
the snapshot completed successfully.
closes #89625