Cleanup dead branch and duplication in ThreadContext#89614
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Aug 25, 2022
original-brownbear:simplify-thread-context-tl
Merged
Cleanup dead branch and duplication in ThreadContext#89614original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:simplify-thread-context-tl
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:simplify-thread-context-tl
Conversation
We never create a stored context that has transient headers to clear while at the same time preserves response headers. Not supporting this path allows for splitting up the logic into 3 distinct methods that are much easier to follow logically. Also, this commit removes a few redundant threadlocal.get and set calls.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
Thanks Nikola! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context stashing keeps showing up in profiling on the network thread. It's not a big deal but easy to simplify and speed up a little:
We never create a stored context that has transient headers to clear while at the same
time preserves response headers. Not supporting this path allows for splitting up
the logic into 3 distinct methods that are much easier to follow logically.
Also, this commit removes a few redundant threadlocal.get and set calls.