Skip to content

Check parent circuit breaker when allocating empty bucket#89568

Merged
elasticsearchmachine merged 12 commits intoelastic:mainfrom
boicehuang:date_hisgram_breaker
Aug 24, 2022
Merged

Check parent circuit breaker when allocating empty bucket#89568
elasticsearchmachine merged 12 commits intoelastic:mainfrom
boicehuang:date_hisgram_breaker

Conversation

@boicehuang
Copy link
Copy Markdown
Contributor

closes #80789

@elasticsearchmachine elasticsearchmachine added v8.5.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 24, 2022
@nik9000 nik9000 self-requested a review August 24, 2022 11:49
@nik9000 nik9000 added >bug :Analytics/Aggregations Aggregations and removed needs:triage Requires assignment of a team area label labels Aug 24, 2022
@nik9000 nik9000 self-assigned this Aug 24, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 24, 2022
@nik9000
Copy link
Copy Markdown
Member

nik9000 commented Aug 24, 2022

@elasticmachine, ok to test

@not-napoleon not-napoleon self-requested a review August 24, 2022 14:49
Copy link
Copy Markdown
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you @boicehuang and @nik9000 , this definitely seems worth having.

@nik9000
Copy link
Copy Markdown
Member

nik9000 commented Aug 24, 2022

I'll fixup the changelog and land this. Sorry about all the trouble with this one. Thanks for opening this.

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 24, 2022
@elasticsearchmachine elasticsearchmachine merged commit 061e643 into elastic:main Aug 24, 2022
@lockewritesdocs lockewritesdocs changed the title check parent circuit breaker when allocating empty bucket Check parent circuit breaker when allocating empty bucket Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants