Skip to content

Operator/slm policy#89567

Merged
grcevski merged 23 commits intoelastic:mainfrom
grcevski:operator/slm_policy
Sep 20, 2022
Merged

Operator/slm policy#89567
grcevski merged 23 commits intoelastic:mainfrom
grcevski:operator/slm_policy

Conversation

@grcevski
Copy link
Copy Markdown
Contributor

@grcevski grcevski commented Aug 24, 2022 •
edited
Loading

This PR adds support for /_slm/policy in file based settings.

Relates to #89183

@grcevski grcevski added >enhancement :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.5.0 labels Aug 24, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Aug 24, 2022

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Aug 24, 2022

Hi @grcevski, I've created a changelog YAML for you.

@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Aug 24, 2022

I plan to document the code a bit more, getting a PR out to ensure I get a start on the testing.

@grcevski grcevski mentioned this pull request Aug 24, 2022
Closed
10 tasks
@grcevski grcevski marked this pull request as draft August 24, 2022 15:23
@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Aug 24, 2022

I'm going to split off the repo part into separate PR.

@grcevski grcevski mentioned this pull request Aug 24, 2022
Merged
@grcevski grcevski mentioned this pull request Aug 25, 2022
Merged
@grcevski grcevski marked this pull request as ready for review September 15, 2022 16:18
@grcevski grcevski requested a review from dakrone September 15, 2022 16:18
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Sep 15, 2022

Hi @grcevski, I've updated the changelog YAML for you.

@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Sep 15, 2022

@elasticsearchmachine run elasticsearch-ci/docs

@grcevski grcevski added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Sep 19, 2022
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Sep 19, 2022
dakrone
dakrone approved these changes Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, it's actually not a super complex change, just large due to testing (yay tests). I'm not super close to the file-based settings stuff, but I assume it's totally okay for a single policy failure to fail the entire operation, is that correct?

@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Sep 19, 2022

I'm not super close to the file-based settings stuff, but I assume it's totally okay for a single policy failure to fail the entire operation, is that correct?

Yes, that's true, any error should fail the entire update, including all other settings that are not SLM specific.

@grcevski grcevski merged commit f0e498b into elastic:main Sep 20, 2022
@grcevski grcevski deleted the operator/slm_policy branch September 20, 2022 12:49
@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Sep 20, 2022

Thanks Lee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grcevski @elasticsearchmachine @dakrone