More tests for enrich processor#89554
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Aug 23, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Adds more tests for the enrich processor around different index types. Right now they all work fine (yay!) but this feels like a good amount of paranoia.
Member
|
These are all missing a human-readable "name" for the test (the |
dakrone
approved these changes
Aug 23, 2022
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding these Nik! I left one comment about adding a description string for the test
Member
Author
I don't tend to include the words "test that" but I have pushed some more descriptive language. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more tests for the enrich processor around different index types.
Right now they all work fine (yay!) but this feels like a good amount of
paranoia.