Wrap async QL task execution in new tracing context#89029
Merged
pugnascotia merged 1 commit intoelastic:mainfrom Aug 2, 2022
Merged
Wrap async QL task execution in new tracing context#89029pugnascotia merged 1 commit intoelastic:mainfrom
pugnascotia merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #84369. Split out from #88443. This PR wraps parts logic in
AsyncTaskManagementServicein a new tracing context. This isnecessary so that a tracing implementation can use the thread context
to propagate tracing headers, but without the code attempting to set the
same key twice in the thread context, which is illegal.