Skip to content

Wrap enrich execute action in new tracing context#89021

Merged
pugnascotia merged 1 commit intoelastic:mainfrom
pugnascotia:use-more-tracing-contexts-part3
Aug 2, 2022
Merged

Wrap enrich execute action in new tracing context#89021
pugnascotia merged 1 commit intoelastic:mainfrom
pugnascotia:use-more-tracing-contexts-part3

Conversation

@pugnascotia
Copy link
Copy Markdown
Contributor

Part of #84369. Split out from #88443. This PR wraps parts logic in
InternalExecutePolicyAction in a new tracing context. This is
necessary so that a tracing implementation can use the thread context
to propagate tracing headers, but without the code attempting to set the
same key twice in the thread context, which is illegal.

@pugnascotia pugnascotia added :Distributed/Ingest Node Execution or management of Ingest Pipelines >refactoring v8.5.0 labels Aug 2, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Aug 2, 2022
Copy link
Copy Markdown
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Rory

@pugnascotia pugnascotia merged commit bc840f9 into elastic:main Aug 2, 2022
@pugnascotia pugnascotia deleted the use-more-tracing-contexts-part3 branch August 2, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >refactoring Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants