[TSDB] Metric fields in the field caps API#88695
Merged
csoulios merged 19 commits intoelastic:mainfrom Aug 4, 2022
Merged
Conversation
in field caps api
Collaborator
|
Hi @csoulios, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
csoulios
commented
Aug 4, 2022
| mapping.endObject(); | ||
| }); | ||
| // Add a keyword dimension as a routing parameter | ||
| mapping.startObject("k").field("type", "keyword").field("time_series_dimension", true).endObject(); |
Contributor
Author
There was a problem hiding this comment.
Adding a keyword dimension field named k, simply because there always must be a routing dimension. It's value is always k
csoulios
commented
Aug 4, 2022
| `time_series_dimension`:: | ||
| preview:[] | ||
| Whether this field is used as a time series dimension. | ||
| Whether this field is used as a time series dimension on all indices. |
Contributor
Author
There was a problem hiding this comment.
@kilfoyle Maybe you have a better take on the doc changes here.
romseygeek
approved these changes
Aug 4, 2022
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. Very comprehensive tests for such a small functional change!
kilfoyle
reviewed
Aug 4, 2022
kilfoyle
reviewed
Aug 4, 2022
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle
reviewed
Aug 4, 2022
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle
approved these changes
Aug 4, 2022
Contributor
Author
|
Thanks everyone for reviewing this so fast! |
|
#89171 (comment) relates to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To assist the user in configuring the visualizations correctly while leveraging TSDB functionality, information about TSDB configuration should be exposed via the field caps API per field.
Especially for metrics fields, it must be clear which fields are metrics and if they belong to only time-series indexes or mixed time-series and non-time-series indexes.
To further distinguish metric fields when they belong to any of the following indices:
This PR modifies the field caps API so that the mapping parameters
time_series_dimensionandtime_series_dimensionare presented only when they are set on fields of time-series indexes. Thoseparameters are completely ignored when they are set on standard (non-time-series) indexes.
This PR revisits some of the conventions adopted by #78790