Fix testCorruptionOnNetworkLayer#88644
Merged
DaveCTurner merged 1 commit intoelastic:masterfrom Jul 20, 2022
Merged
Conversation
`POST _cluster/reroute?retry_failed` doesn't reset the failure counter on any `INITIALIZING` shards, and waiting for no `INITIALIZING` shards isn't quite enough to ensure that we've finished all possible retries because there could instead be an ongoing async fetch. This commit fixes this using a `ClusterStateObserver` to observe the retry counter instead of using the cluster health action. Relates elastic#88314 Closes elastic#88615
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST _cluster/reroute?retry_faileddoesn't reset the failure counteron any
INITIALIZINGshards, and waiting for noINITIALIZINGshardsisn't quite enough to ensure that we've finished all possible retries
because there could instead be an ongoing async fetch.
This commit fixes this using a
ClusterStateObserverto observe theretry counter instead of using the cluster health action.
Relates #88314
Closes #88615