Fix ReactiveStorageIT#testScaleWhileShrinking#88630
Merged
fcofdez merged 3 commits intoelastic:mainfrom Jul 25, 2022
Merged
Conversation
This commit fixes ReactiveStorageIT#testScaleWhileShrinking, the TestFileStore missed handling an exception while the total space was calculated. This made the get node stats to fail therefore the actual capacity was computed incorrectly. In addition to that, when the shards are colocated, the index files that were part of the other node take a while to get deleted. This made impossible to allocate the shard anywhere, therefore the test failed in these cases. Closes elastic#88430
henningandersen
approved these changes
Jul 25, 2022
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes ReactiveStorageIT#testScaleWhileShrinking, the
TestFileStore missed handling an exception while the total space
was calculated. This made the get node stats to fail therefore
the actual capacity was computed incorrectly. In addition to that,
when the shards are colocated, the index files that were part of
the other node take a while to get deleted. This made impossible
to allocate the shard anywhere, therefore the test failed in these
cases.
Closes #88430