Fix ReactiveStorageIT#testScaleDuringSplitOrClone#88607
Merged
fcofdez merged 5 commits intoelastic:mainfrom Aug 9, 2022
Merged
Fix ReactiveStorageIT#testScaleDuringSplitOrClone#88607fcofdez merged 5 commits intoelastic:mainfrom
fcofdez merged 5 commits intoelastic:mainfrom
Conversation
Sometimes the autoscaling decider returns an empty response when the service does not have enough information to provide an autoscaling decision, i.e. when a new node joins it tries to fetch the new node memory info and this might take a while. This commits adds a busy assertion to ensure that a valid autoscaling capacity is provided eventually. Closes elastic#88478
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
reviewed
Jul 21, 2022
| // provides a complete autoscaling capacity response | ||
| assertBusy(() -> { | ||
| // validate initial state looks good | ||
| GetAutoscalingCapacityAction.Response response = capacity(); |
Member
There was a problem hiding this comment.
If the NPE is just because there is no result in the response, why not only assertBusy getting the capacity() call, and leave the rest out of it?
Contributor
Author
There was a problem hiding this comment.
Yes, that makes sense, it just felt like the entire assertion block belonged together, but it would make the test slower if there's some other failure. I'll amend it 👍
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the autoscaling decider returns an empty response when
the service does not have enough information to provide an autoscaling
decision, i.e. when a new node joins it tries to fetch the new node
memory info and this might take a while. This commits adds a busy
assertion to ensure that a valid autoscaling capacity is provided
eventually.
Closes #88478