Add one test for execution context in watcher compare condition#88466
Merged
stu-elastic merged 1 commit intoelastic:masterfrom Jul 13, 2022
Merged
Add one test for execution context in watcher compare condition#88466stu-elastic merged 1 commit intoelastic:masterfrom
stu-elastic merged 1 commit intoelastic:masterfrom
Conversation
Add one test to confirm the below watcher compare condition is always
met.
```
"condition": {
"compare": {
"ctx.execution_time": {
"gte": "<{now-5m}>"
}
}
}
```
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #88408
This PR adds one test for execution context in the watcher compare condition, which is equivalent to the below compare condition.
{ "condition" : { "compare" : { "ctx.execution_time" : { "gte" : "<{now-5m}>" } } } }This test should always pass and actually passes in master branch but fails in 7.17 branch. So, backport PR will append necessary adjustment (bug fix) on top of this.
Question: I don't think this PR needs a changelog, right?