Skip to content

Fix ConcurrentSnapshotsIT.testMasterFailoverDuringStaleIndicesCleanup#88065

Merged
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:88061
Jun 28, 2022
Merged

Fix ConcurrentSnapshotsIT.testMasterFailoverDuringStaleIndicesCleanup#88065
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:88061

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

As a result of #86514 we now
remove the snapshot delete from the cluster state before cleaning up
stale shard level blobs so we have to block master earlier on deleting the
root level index-N blob to get the desired cluster state where delete
and snapshot creation are both in the cluster state at the same time.

closes #88061

As a result of #86514 we now
remove the snapshot delete from the cluster state before cleaning up
stale shard level blobs so we have to block master earlier on deleting the
root level index-N blob to get the desired cluster state where delete
and snapshot creation are both in the cluster state at the same time.

closes #88061
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.4.0 labels Jun 27, 2022
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Jun 27, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/part-2

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/packaging-tests-unix-sample

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/packaging-tests-unix-sample

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Thanks Tanguy!

@original-brownbear original-brownbear merged commit 8e9cd99 into elastic:master Jun 28, 2022
@original-brownbear original-brownbear deleted the 88061 branch June 28, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reproducible Failure in ConcurrentSnapshotsIT.testMasterFailoverDuringStaleIndicesCleanup

3 participants