Skip to content

[TRANSFORM] Add YAML test assertions for roles in transform configs#88052

Merged
droberts195 merged 1 commit intoelastic:masterfrom
droberts195:transform-auth-yaml-tests
Jun 27, 2022
Merged

[TRANSFORM] Add YAML test assertions for roles in transform configs#88052
droberts195 merged 1 commit intoelastic:masterfrom
droberts195:transform-auth-yaml-tests

Conversation

@droberts195
Copy link
Copy Markdown

In #87570 authorization info was added to transform listings.
Authorization information was also implicitly added to transform
update responses. However, YAML tests were not added to either.
This PR adds some assertions to the YAML tests for getting transforms
and transform updates to prove that the responses really do include
authorization information.

In elastic#87570 authorization info was added to transform listings.
Authorization information was also implicitly added to transform
update responses. However, YAML tests were not added to either.
This PR adds some assertions to the YAML tests for getting transforms
and transform updates to prove that the responses really do include
authorization information.
@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform v8.4.0 labels Jun 27, 2022
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 27, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Copy Markdown

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit f953f15 into elastic:master Jun 27, 2022
@droberts195 droberts195 deleted the transform-auth-yaml-tests branch June 27, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants