Skip to content

[8.3] Make CBE message creation more robust (#87881)#87883

Merged
elasticsearchmachine merged 1 commit intoelastic:8.3from
DaveCTurner:backport/8.3/pr-87881
Jun 21, 2022
Merged

[8.3] Make CBE message creation more robust (#87881)#87883
elasticsearchmachine merged 1 commit intoelastic:8.3from
DaveCTurner:backport/8.3/pr-87881

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

Backports the following commits to 8.3:

Child circuit breakers rely on proper matching of acquire/release pairs.
This can be tricky to get right. If we get it wrong and accidentally
double-release a CB then it may end up with a negative `used` value.
This is definitely a bad situation in which to find ourselves, but today
in production it's made a whole lot worse because it causes exceptions
on every attempt to report a `CircuitBreakerStats` or to construct a
parent `CircuitBreakingException`.

This commit makes the message construction and stats serialization a
little more robust so that it's clearer what is going on in production.

Relates elastic#86059
@DaveCTurner DaveCTurner added :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team labels Jun 21, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@DaveCTurner
Copy link
Copy Markdown
Member Author

@elasticmachine please run elasticsearch-ci/part-1

@elasticsearchmachine elasticsearchmachine merged commit 4586c0d into elastic:8.3 Jun 21, 2022
@DaveCTurner DaveCTurner deleted the backport/8.3/pr-87881 branch June 21, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload Team:Core/Infra Meta label for core/infra team v8.3.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants