Mark apm_user for removal in "a future version"#87674
Mark apm_user for removal in "a future version"#87674pugnascotia merged 9 commits intoelastic:mainfrom
apm_user for removal in "a future version"#87674Conversation
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @sqren, I've created a changelog YAML for you. Note that since this PR is labelled |
ywangd
left a comment
There was a problem hiding this comment.
I think we should use the next major release instead of 9.0 since the major release strategy is not entirely clear. Also most places in the code use "the next major release/version", e.g.:
We could be even more generic with "a future major release". It was not so uncommon that we decided to keep a deprecated feature across majors, and in that case the message may be confusing. |
|
I changed the deprecation notice to "This role will be removed in a future major release. Please use editor and viewer roles instead" |
|
@elasticmachine update branch |
|
@pugnascotia CI fails for this PR because it does not like the area label of deprecation. Existing ones are elasticsearch/build-tools-internal/src/main/resources/changelog-schema.json Lines 177 to 191 in fc09896 But none of them seems to fit the deprecation here which is for a builtin role. What would be your recommendation? Thanks! |
|
It's fine to add a new area to that last. Obviously we don't want lots and lots of areas, but if we need a another one then let's just add it. "Authorization" or "Security" would be OK, something like that. |
|
I dropped this but this is still something I'd like to merge. @pugnascotia Afaict I added "Authorization" in 72b1163. Still, I'm seeing a bunch of failures. What's the suggested way forward? |
|
@elasticmachine update branch |
|
@sqren I updated the branch but there are formatting problems. To fix them, update your local branch checkout and run: Then commit and push. I don't believe we have automation for this at present. |
apm_user for removal in 9.0apm_user for removal in "a future version"
Request changes have been implemented.
Meta issue: elastic/kibana#116760
The
apm_userrole was marked as deprecated in 7.13 and was supposed to be removed in 8.0 but it didn't happen. Now we are aiming to remove the role in 9.0 and are updating the deprecation message.All mentions of
apm_userrole have been removed from docs and in-product mentions in elastic/kibana#132790.