Add support for VERSION field type in SQL and EQL#87590
Merged
luigidellaquila merged 44 commits intoelastic:masterfrom Jun 23, 2022
Merged
Conversation
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
and add new test cases
- better type checks (avoid unpredictable automatic casts) - support multiple casts - add further test cases
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
Luegg
approved these changes
Jun 13, 2022
Contributor
Luegg
left a comment
There was a problem hiding this comment.
Looks generally good to me. But can you give an example of the tests that failed?
docs/changelog/85502.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 85502 | |||
Contributor
There was a problem hiding this comment.
this file is no longer needed
Member
Author
|
@Luegg the failing stack trace was the following: It reproduced deterministically with a specific seed: |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting #85502, reverted after a CI failure (error on serialization of ConstantProcessor containing a Version object).
The problem was reported by a randomized test, probably it was not identified during the review phase because it's unlikely to happen on CSV spec test suite, due to relatively small result sets.
The applied fix consists in letting ConstantProcessor manage Version objects as a special case and serialize them directly, without relying on StreamInput/Output generic value serialization.
A more natural solution would have been to let StreamInput/Output manage Version objects natively, but it was discarded because Version is in x-pack and cannot be directly referenced/instantiated in Server module (unless we move it and change its license).
Fixes #83375