Skip to content

Tests for synthetic _source from translog#87578

Merged
nik9000 merged 1 commit intoelastic:masterfrom
nik9000:synthetic_source_test_translog_load
Jun 16, 2022
Merged

Tests for synthetic _source from translog#87578
nik9000 merged 1 commit intoelastic:masterfrom
nik9000:synthetic_source_test_translog_load

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Jun 9, 2022

This adds tests to make sure that we use all of the normal synthetic
source machinery, even when loading from the translog. So all GETs on
synthetic source indices will require an in memory index. That'll be an
extra cost on indices that are updated very very frequently.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics v8.4.0 labels Jun 9, 2022
@nik9000 nik9000 requested a review from romseygeek June 9, 2022 21:04
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 9, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 mentioned this pull request Jun 9, 2022
50 tasks
This adds tests to make sure that we use all of the normal synthetic
source machinery, even when loading from the translog. So all GETs on
synthetic source indices will require an in memory index. That'll be an
extra cost on indices that are updated very very frequently.
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jun 15, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/clients-team (Team:Clients)

Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit cf154fd into elastic:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Clients Meta label for clients team >test Issues or PRs that are addressing/adding tests v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants