Convert o.e.cluster to use Map in public methods#87168
Merged
rjernst merged 6 commits intoelastic:masterfrom Jun 3, 2022
Merged
Convert o.e.cluster to use Map in public methods#87168rjernst merged 6 commits intoelastic:masterfrom
rjernst merged 6 commits intoelastic:masterfrom
Conversation
Many classes that use ImmutableOpenMap expose the maps directly, when the consumers actually only use methods from the base Map interface. This commit converts public methods in subpackages of o.e.cluster to return Map instead of ImmutableOpenMap. Note that o.e.cluster classes are not yet converted because they require more involved changes. relates elastic#86239
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
35 tasks
commit 844f73e382787f9be995639da3caee16db8ba3cd Merge: ce841f089d1 767fd68 Author: Ryan Ernst <ryan@iernst.net> Date: Wed Jun 1 05:46:32 2022 -0700 Merge branch 'master' into hppc/cluster_public commit ce841f089d1fd3a6af1c86ce2a242238b7ccdf79 Author: Ryan Ernst <ryan@iernst.net> Date: Tue May 31 06:15:01 2022 -0700 snapshotsinprogress commit f4a752c81a2633eb586b9f1ea13ffe6f3c4ba74d Author: Ryan Ernst <ryan@iernst.net> Date: Tue May 31 06:08:06 2022 -0700 clusterinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many classes that use ImmutableOpenMap expose the maps directly, when
the consumers actually only use methods from the base Map interface.
This commit converts public methods in subpackages of o.e.cluster to
return Map instead of ImmutableOpenMap. Note that o.e.cluster classes
are not yet converted because they require more involved changes.
relates #86239