Avoid circuit breaker trips in shutdown node actions (#86047)#86993
Merged
elasticsearchmachine merged 2 commits intoelastic:8.2from May 23, 2022
Merged
Avoid circuit breaker trips in shutdown node actions (#86047)#86993elasticsearchmachine merged 2 commits intoelastic:8.2from
elasticsearchmachine merged 2 commits intoelastic:8.2from
Conversation
When adding or deleting node shutdown metadata, it is important that as few things go wrong as possible. Since these actions do not do anything with memory, there is no reason they should trip the circuit breaker, but they might accidentally if there is pressure on the system. This commit declares the rest and transport actions as not capable of tripping the circuit breaker. closes elastic#84847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.
closes #84847