Randomize connection mode for AbstractMultiClustersTestCase#86865
Merged
cbuescher merged 1 commit intoelastic:masterfrom May 24, 2022
Merged
Randomize connection mode for AbstractMultiClustersTestCase#86865cbuescher merged 1 commit intoelastic:masterfrom
cbuescher merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Member
Author
|
I'm mostly opening this issue for discussion and to see if randomization of the connection mode breaks any of the existing tests. |
Currently tests extending AbstractMultiClustersTestCase, i.e. mostly the CCS tests, use the default connection mode configuration of the abstract base tests, which is the default "sniff" mode. In order to increase coverage for "proxy" mode connections this change starts to randomize the connection type in the setup. Subclasses of this test are free to use or overwrite this behaviour. Relates to elastic#84481
818db4c to
9872871
Compare
Contributor
|
heya @dnhatn does this make sense to you? Would you have time to review this PR? |
Member
Author
|
@dnhatn thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently tests extending AbstractMultiClustersTestCase, i.e. mostly the CCS
tests, use the default connection mode configuration of the abstract base tests,
which is the default "sniff" mode. In order to increase coverage for "proxy"
mode connections this change starts to randomize the connection type in the
setup. Subclasses of this test are free to use or overwrite this behaviour.
Relates to #84481