Skip to content

Remove test that relied on JWT feature flag#86499

Merged
elasticsearchmachine merged 3 commits intoelastic:masterfrom
tvernum:fix/jwt-snapshot-test
May 23, 2022
Merged

Remove test that relied on JWT feature flag#86499
elasticsearchmachine merged 3 commits intoelastic:masterfrom
tvernum:fix/jwt-snapshot-test

Conversation

@tvernum
Copy link
Copy Markdown
Contributor

@tvernum tvernum commented May 6, 2022

The testJwtRealmDependsOnBuildType test assumed that JWT was behind a
feature flag which is no longer the case

Resolves: #85407

The testJwtRealmDependsOnBuildType test assumed that JWT was behind a
feature flag which is no longer the case

Resolves: elastic#85407
@tvernum tvernum added >test Issues or PRs that are addressing/adding tests :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.3.0 labels May 6, 2022
@tvernum tvernum requested a review from justincr-elastic May 6, 2022 02:31
@elasticmachine elasticmachine added the Team:Security Meta label for security team label May 6, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

@tvernum
Copy link
Copy Markdown
Contributor Author

tvernum commented May 6, 2022

@elasticmachine update branch

Copy link
Copy Markdown
Contributor

@justincr-elastic justincr-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum
Copy link
Copy Markdown
Contributor Author

tvernum commented May 23, 2022

@elasticmachine update branch

@tvernum tvernum added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 23, 2022
@elasticsearchmachine elasticsearchmachine merged commit 005a2ff into elastic:master May 23, 2022
@tvernum tvernum deleted the fix/jwt-snapshot-test branch May 23, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] InternalRealmsTests testJwtRealmDependsOnBuildType failing

4 participants