Fix DesiredBalanceReconcilerTests#testFailsNewPrimariesIfNoDataNodes#86432
Merged
DaveCTurner merged 1 commit intoelastic:feature/desired-balance-allocatorfrom May 5, 2022
Conversation
This test was checking that the reconciler does nothing if the desired balance is empty, but that wasn't the case: if there are no data nodes then we fail the allocation of new primaries. This commit removes these unnecessary assertions.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
73 tasks
idegtiarenko
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was checking that the reconciler does nothing if the desired
balance is empty, but that wasn't the case: if there are no data nodes
then we fail the allocation of new primaries. This commit removes these
unnecessary assertions.