[Test] Fix authentication creation in example project#86385
Merged
ywangd merged 3 commits intoelastic:masterfrom May 3, 2022
Merged
[Test] Fix authentication creation in example project#86385ywangd merged 3 commits intoelastic:masterfrom
ywangd merged 3 commits intoelastic:masterfrom
Conversation
In elastic#86206, we closed down Authentication constructors to favour dedicated convenient methods for instantiation. The constructor usages in the example project were however left out (another refactor fallout). Relates: elastic#86206 Resolves: elastic#86378
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Member
Author
Done. I was going to but your PR wasn't merged when this one got raised. |
n1v0lg
approved these changes
May 3, 2022
| new RealmRef("test", "test", "node"), new RealmRef("test", "test", "node")); | ||
| Authentication authentication = Authentication | ||
| .newRealmAuthentication(new User("bar", "not_superuser"), new RealmRef("test", "test", "node")) | ||
| .runAs(new User("joe", "custom_superuser"), new RealmRef("test", "test", "node")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #86206, we closed down Authentication constructors to favour
dedicated convenient methods for instantiation. The constructor usages
in the example project were however left out (another refactor fallout).
Relates: #86206
Resolves: #86378