Add parameter to exclude indices in a snapshot from response#86269
Merged
original-brownbear merged 8 commits intoelastic:masterfrom Apr 29, 2022
original-brownbear:82937
Merged
Add parameter to exclude indices in a snapshot from response#86269original-brownbear merged 8 commits intoelastic:masterfrom original-brownbear:82937
original-brownbear merged 8 commits intoelastic:masterfrom
original-brownbear:82937
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @original-brownbear, I've created a changelog YAML for you. |
| final boolean includeIndices = randomBoolean(); | ||
| final List<SnapshotInfo> defaultSorting = clusterAdmin().prepareGetSnapshots(repoName) | ||
| .setOrder(order) | ||
| .setIndices(includeIndices) |
Contributor
There was a problem hiding this comment.
In my opinion both indices and includeIndices sounds quiet generic and might be confusing.
Should they be called includeIndexNames?
|
|
||
| private boolean verbose = DEFAULT_VERBOSE_MODE; | ||
|
|
||
| private boolean indices = true; |
Contributor
There was a problem hiding this comment.
I think this is very generic and confusing outside of the issue context.
| @@ -143,7 +143,7 @@ public GetSnapshotsRequestBuilder setOrder(SortOrder order) { | |||
| } | |||
|
|
|||
| public GetSnapshotsRequestBuilder setIndices(boolean indices) { | |||
Contributor
There was a problem hiding this comment.
Do you mind renaming this one as well?
idegtiarenko
approved these changes
Apr 29, 2022
Contributor
Author
|
@elasticmachine update branch |
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
Just a drive-by comment. Can we also update the PR description to mention what this PR changes?
Co-authored-by: Henning Andersen <33268011+henningandersen@users.noreply.github.com>
Contributor
Author
|
Description added. |
Contributor
Author
|
Thanks Ievgen + Henning! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parameter
index_namesto the get snapshots API so that users may exclude the potentially very long index name lists when listing out snapshots.Not super optimized but good enough to fix the REST response in currently broken cases and generally make the API a little lighter to use for debugging common issues.
closes #82937