[Test] Ensure correct randomization for API key metadata#86218
Merged
elasticsearchmachine merged 2 commits intoelastic:masterfrom Apr 27, 2022
Merged
[Test] Ensure correct randomization for API key metadata#86218elasticsearchmachine merged 2 commits intoelastic:masterfrom
elasticsearchmachine merged 2 commits intoelastic:masterfrom
Conversation
Similar to elastic#86188, the test failure elastic#86211 is caused by incorrect randomziation. In this case, the API metadata was expected to be null in some cases. This PR fixes it by ensuring the correct randomisation. Resolves: elastic#86211
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Apr 27, 2022
Contributor
n1v0lg
left a comment
There was a problem hiding this comment.
LGTM!
I think SetSecurityUserProcessorTests::testApiKeyPopulation might have the same issue here:
Member
Author
Absolutely! Excellent find, thanks! I pushed the fix as part of this PR as well. |
Contributor
|
👍 ship it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #86188, the test failure #86211 is also caused by incorrect
randomziation due to refactoring.
In this case, the API metadata was expected to be null in some cases.
This PR fixes it by ensuring the correct randomisation.
Resolves: #86211