Remove hppc from top hits agg#86150
Merged
rjernst merged 3 commits intoelastic:masterfrom Apr 27, 2022
Merged
Conversation
The top hits aggregator uses hppc for keeping track of leaf bucket collectors. This commit converts it to use HashMap. relates elastic#84735
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Apr 26, 2022
Member
nik9000
left a comment
There was a problem hiding this comment.
Could you use LongObjectPagedHashMap here instead? It's known not to allocate. I know top_hits isn't the fastest thing, but we may as well use the tools we build for aggs in aggs.
Member
Author
|
Ok, switched to |
Member
Author
|
@nik9000 CI looks happy now, any other concerns? |
nik9000
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top hits aggregator uses hppc for keeping track of leaf bucket
collectors. This commit converts it to use HashMap.
relates #84735