Remove hppc from deletion policy#86072
Merged
rjernst merged 4 commits intoelastic:masterfrom Apr 21, 2022
Merged
Conversation
The CombinedDeletionPolicy keeps ref counts for each index snapshot using an hppc primitive map. This commit converts it to use a standard HashMap. relates elastic#84735
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Apr 21, 2022
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, one suggestion on making it potentially even faster and a little simpler than it is today but not important :)
| + releasingCommit | ||
| + "]"; | ||
| final int refCount = snapshottedCommits.addTo(releasingCommit, -1); // release refCount | ||
| final int refCount = snapshottedCommits.merge(releasingCommit, -1, Integer::sum); // release refCount |
Contributor
There was a problem hiding this comment.
NIT: I think we could even do
final Integer refCount = snapshottedCommits.compute(releaseCommit, (key, count) -> {
if (count == 1) {
return null;
}
return count - 1;
})and adjust the logic below to a null check instead of == 0 and drop the conditional remove from the map. merge seems kind of (slightly) wrong here when we assume that we have an entry in the map for sure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CombinedDeletionPolicy keeps ref counts for each index snapshot
using an hppc primitive map. This commit converts it to use a standard
HashMap.
relates #84735