Remove invalid todo in ShardGetService#85921
Merged
elasticsearchmachine merged 3 commits intoelastic:masterfrom Apr 20, 2022
Merged
Remove invalid todo in ShardGetService#85921elasticsearchmachine merged 3 commits intoelastic:masterfrom
elasticsearchmachine merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Member
❤️ |
nik9000
approved these changes
Apr 19, 2022
Member
|
@elasticmchine, ok to test |
Member
|
@elasticmachine update branch that test failure can't be caused by this |
Member
maybe it's already fixed...... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
668d557 added some
todoinShardGetServicesuggest that source might parsed and available in the sourceLookup.elasticsearch/src/main/java/org/elasticsearch/index/get/ShardGetService.java
Line 315 in 668d557
elasticsearch/src/main/java/org/elasticsearch/index/get/ShardGetService.java
Line 431 in 668d557
However ,
SourceLookupinShardGetServicehas been remove in #20158 which made thesetodoinvalid.One of them has been removed in #83152
This PR remove the left invalid
todoinShardGetService