Remove SnapshotClient from HLRC#85845
Merged
elasticsearchmachine merged 11 commits intoelastic:masterfrom Apr 14, 2022
Merged
Conversation
This removes the `SnapshotClient` from the high level rest client, rewriting the tests to use the low-level client instead. Relates to elastic#83423
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
66 tasks
assertThat is actual then expected (or, well, actual and then matcher/condition-y thing).
joegallo
approved these changes
Apr 13, 2022
Contributor
joegallo
left a comment
There was a problem hiding this comment.
LGTM, your call whether my ✅ is good enough given my commits here. And also if you don't like any of my commits, we can totally undo them.
Member
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
SnapshotClientfrom the high level rest client, rewriting the tests to use thelow-level client instead.
Relates to #83423