Make the ILM Move to Error Step Batched#85565
Merged
original-brownbear merged 6 commits intoelastic:masterfrom Apr 1, 2022
original-brownbear:81880
Merged
Make the ILM Move to Error Step Batched#85565original-brownbear merged 6 commits intoelastic:masterfrom original-brownbear:81880
original-brownbear merged 6 commits intoelastic:masterfrom
original-brownbear:81880
Conversation
Simple solution by just moving this to the infrastructure we already have for the other step tasks. There might be optimizations here still but this should be a big enough improvement in the short term for all practical cases. closes #81880
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @original-brownbear, I've created a changelog YAML for you. |
dakrone
reviewed
Mar 31, 2022
| logger.debug(messageSupplier, e); | ||
| } else { | ||
| logger.error(messageSupplier, e); | ||
| assert false : new AssertionError("unexpected exception", e); |
Member
There was a problem hiding this comment.
I honestly don't remember or know why we have this assert, but are we okay dropping it?
Contributor
Author
There was a problem hiding this comment.
Oh no we shouldn't my bad ... will revert in a second. I believe we added this because we had some NPE bug in the move to error logic which caused us to the underlying error (it's been a while but it was something along those lines).
Thanks so much for spotting this!
Contributor
Author
|
Jenkins run elasticsearch-ci/bwc (Jenkins issue) |
Contributor
Author
|
@elasticmachine update branch (there's some BwC serialization failure ...) |
Contributor
Author
|
Npnp +Thanks Lee! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple solution by just moving this to the infrastructure we already have for the other
step tasks. There might be optimizations here still but this should be a big enough improvement
in the short term for all practical cases.
closes #81880