Remove HLRC IndicesClient and related classes.#85492
Remove HLRC IndicesClient and related classes.#85492elasticsearchmachine merged 37 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/clients-team (Team:Clients) |
| client().performRequest(refreshRequest); | ||
| } | ||
|
|
||
| protected static RefreshResponse refresh(String index) throws IOException { |
There was a problem hiding this comment.
Reusing server module's CreateIndexResponse, AcknowledgedResponse and RefreshResponse in tests.
These classes aren't part of the hlrc code base, but does provide us in tests the capabilities to easily parse the responses for the related apis.
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one comment about duplicate helper methods
| protected static Map<?, ?> toMap(Response response) throws IOException { | ||
| return XContentHelper.convertToMap(XContentType.JSON.xContent(), response.getEntity().getContent(), false); | ||
| } |
There was a problem hiding this comment.
Is it necessary to have the Map<?, ?> response for this? We already have the responseAsMap method in ESRestTestCase that returns a Map<String, Object>, do we need both?
There was a problem hiding this comment.
I must have missed that... I replaced all custom toMap(...) methods from tests to use this one.
I will remove this one and make everything use responseAsMap(...). But first the pr ci build needs to be happy :)
Relates to #83423