Add test for previously broken behaviour on dotted array field#85081
Merged
javanna merged 4 commits intoelastic:masterfrom Mar 18, 2022
Merged
Add test for previously broken behaviour on dotted array field#85081javanna merged 4 commits intoelastic:masterfrom
javanna merged 4 commits intoelastic:masterfrom
Conversation
Previously, when using dynamic: false, an array field with a dot in its name, whose suffix matched a mapped field’s name, had its values merged with the mapped field unexpectedly. This has been fixed by elastic#79922 This commit adds a test for that scenario and verifies that the bug is fixed. Closes elastic#65333
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Mar 18, 2022
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
I fixed a bug by accident, nice!
| b.field("myfield", "value1"); | ||
| b.array("something.myfield", "value2", "value3"); | ||
| })); | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add a comment here clarifying what we expect? Something like:
// dynamic is false, so `something.myfield` should be ignored entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when using dynamic: false, an array field with a dot in its name, whose suffix matched
a mapped field’s name, had its values merged with the mapped field unexpectedly. This has been fixed by #79922
This commit adds a test for that scenario and verifies that the bug is fixed.
Closes #65333