Fix mock object creation in DelegatePki HLRC test#84468
Merged
elasticsearchmachine merged 2 commits intoelastic:8.1from Mar 1, 2022
Merged
Fix mock object creation in DelegatePki HLRC test#84468elasticsearchmachine merged 2 commits intoelastic:8.1from
elasticsearchmachine merged 2 commits intoelastic:8.1from
Conversation
This test would create objects with an authentication_type of "API_KEY", but with a real authentication realm (rather than the API key synthetic realm). It is not possible to create an object like that on the server, so the test was asserting behaviour that cannot exist, and should not be subject to test constraints. This commit fixes the mock object creation to always create more realistic objects. Relates: elastic#84396 Resolves: elastic#84433
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Mar 1, 2022
Member
ywangd
left a comment
There was a problem hiding this comment.
LGTM
I have a task to prevent creation of invalid Authentication on the server side which should help get rid of these problems (especially since we don't have HLRC in 8.2+). But it's a big changeset and I need find time for it.
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test would create objects with an authentication_type of
"API_KEY", but with a real authentication realm (rather than the API
key synthetic realm).
It is not possible to create an object like that on the server, so the
test was asserting behaviour that cannot exist, and should not be
subject to test constraints.
This commit fixes the mock object creation to always create more
realistic objects.
Relates: #84396
Resolves: #84433