Simplify Store$MetadataSnapshot and friends#84357
Merged
DaveCTurner merged 1 commit intoelastic:masterfrom Feb 28, 2022
Merged
Conversation
`TransportNodesListShardStoreMetadata$StoreFilesMetadata` and `Store$MetadataSnapshot` are both morally-speaking records, and `LoadedMetadata` is really the same as `MetadataSnapshot`. This commit turns them into real records, gets rid of the unnecessary extra class, and renames some of the accessors. Spotted while working on elastic#84034
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
@elasticmachine please run elasticsearch-ci/part-1 |
Member
Author
|
@elasticmachine please run elasticsearch-ci/packaging-tests-unix-sample |
arteam
approved these changes
Feb 24, 2022
Contributor
arteam
left a comment
There was a problem hiding this comment.
Very nice refactoring! Thanks David!
idegtiarenko
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransportNodesListShardStoreMetadata$StoreFilesMetadataandStore$MetadataSnapshotare both morally-speaking records, andLoadedMetadatais really the same asMetadataSnapshot. This committurns them into real records, gets rid of the unnecessary extra class,
and renames some of the accessors.
Spotted while working on #84034