Remove LegacyCTRAL from AutoCreateAction#84170
Merged
DaveCTurner merged 5 commits intoelastic:masterfrom Mar 2, 2022
Merged
Conversation
This was referenced Feb 18, 2022
999f845 to
7e2ff44
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
reviewed
Mar 1, 2022
| }; | ||
| } | ||
|
|
||
| ClusterState execute( |
Contributor
There was a problem hiding this comment.
Is it worth a comment on the implied contract w.r.t. returning a clusterState, calling success/failure on the taskContext, and updating successfulRequests? It looks to me like you're doing all the juggling just fine, but some future developer might be happy to add a new return case and think that just satisfying the compiler here is sufficient.
Member
Author
There was a problem hiding this comment.
Yes, good point. I added a comment in 6be0514 and also an assertion to enforce it.
joegallo
approved these changes
Mar 1, 2022
Contributor
joegallo
left a comment
There was a problem hiding this comment.
LGTM, I'd like to see a comment about it, but I'm not going to block on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #83784