Test doc-value-based searches on older indices#83844
Merged
ywelsch merged 3 commits intoelastic:masterfrom Feb 15, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
32 tasks
javanna
approved these changes
Feb 15, 2022
Contributor
javanna
left a comment
There was a problem hiding this comment.
I left one small comment, LGTM otherwise
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class DocValueOnlyFieldsIT extends ESClientYamlSuiteTestCase { |
Contributor
There was a problem hiding this comment.
I think I follow what is happening here, but maybe for posterity, would you mind adding some javadocs about what this class does and its peculiarity? The maybe not so intuitive part is that it will rely on yaml tests but the setup is done differently, maybe expand on why etc.?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests doc-value-based searches against indices from 5.x / 6.x clusters.
Relates #81210