Remove LegacyCTRAListener from ShardStateAction#83842
Merged
elasticsearchmachine merged 3 commits intoelastic:masterfrom Feb 11, 2022
Merged
Conversation
16 tasks
joegallo
approved these changes
Feb 11, 2022
Contributor
joegallo
left a comment
There was a problem hiding this comment.
LGTM, but I find the .success(task, task) a bit bleh -- if this ends up being a popular pattern for handling these, then a .success(task) arity that juggles the types just so might be handy.
I like this pattern, though! It makes me want to revisit my two previous PRs and give them the same treatment.
Member
Author
|
Changed my mind, I think this pattern is tricksy for the general reason that re-using listeners is tricksy. It'd be worth it if profiling shows we create too many objects here but otherwise I would like to keep things clear - see 5f93f8e. |
Member
Author
|
@elasticmachine please run elasticsearch-ci/bwc |
Contributor
|
Still LGTM. |
Member
Author
|
Hit #83567 twice :( @elasticmachine please run elasticsearch-ci/bwc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #83784