Accept only single tasks at master service#83829
Merged
elasticsearchmachine merged 1 commit intoelastic:masterfrom Feb 11, 2022
Merged
Accept only single tasks at master service#83829elasticsearchmachine merged 1 commit intoelastic:masterfrom
elasticsearchmachine merged 1 commit intoelastic:masterfrom
Conversation
Today `MasterService` (and `TaskBatcher`) allow callers to submit a collection of tasks that will be executed all at once. Support for batches of tasks makes things more complicated than they need to be, noting that (since elastic#83803) in production code we only ever submit single tasks. This commit specializes things to accept only single tasks.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today
MasterService(andTaskBatcher) allow callers to submit acollection of tasks that will be executed all at once. Support for
batches of tasks makes things more complicated than they need to be,
noting that (since #83803) in production code we only ever submit single
tasks. This commit specializes things to accept only single tasks.