Move aggregation builders under VersionedNamedWriteable#83598
Merged
cbuescher merged 1 commit intoelastic:masterfrom Feb 8, 2022
Merged
Move aggregation builders under VersionedNamedWriteable#83598cbuescher merged 1 commit intoelastic:masterfrom
cbuescher merged 1 commit intoelastic:masterfrom
Conversation
In elastic#81809 we introduced a mechanism to check searializability of search request to earlier version nodes already on the coordinating node. This requires knowledge about the version that NamedWritable classes have been introduced, which is why we started moving classes that are used inside the search request under the VersionedNamedWriteable interface to make sure future additions implement the mthod that provides the version information. This change moves aggregation builders under that interface. Most builders have been around long before version 7.0, so we return an empty version tag for them. The newer ones return the version they were first released in.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Feb 7, 2022
Member
Author
|
Thanks a lot @nik9000 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #81809 we introduced a mechanism to check searializability of search request
to earlier version nodes already on the coordinating node. This requires
knowledge about the version that NamedWritable classes have been introduced,
which is why we started moving classes that are used inside the search request
under the VersionedNamedWriteable interface to make sure future additions
implement the mthod that provides the version information.
This change moves aggregation builders under that interface. Most builders
have been around long before version 7.0, so we return an empty version tag for them.
The newer ones return the version they were first released in.