Remove unused security methods/classes from HLRC#83571
Merged
tvernum merged 1 commit intoelastic:masterfrom Feb 8, 2022
Merged
Remove unused security methods/classes from HLRC#83571tvernum merged 1 commit intoelastic:masterfrom
tvernum merged 1 commit intoelastic:masterfrom
Conversation
The High Level Rest Client (HLRC) is deprecated and is no longer shipped as a standalone artifact. It can now be safely removed from the ES codebase. This commit removes all security methods from the HLRC "SecurityClient", along with their associated Request/Response classes. All remaining methods and classes are used by existing tests and will need to be reviewed. Relates: elastic#83423
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
albertzaharovits
approved these changes
Feb 7, 2022
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
-2358 nice stats
I only want to review PRs like this.
LGTM
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The High Level Rest Client (HLRC) is deprecated and is no longer
shipped as a standalone artifact.
It can now be safely removed from the ES codebase.
This commit removes unused all security methods from the HLRC
SecurityClient, along with their associated Request/Responseclasses.
All remaining methods and classes are used by existing tests and will
need to be reviewed.
Relates: #83423