Merged
Conversation
We are in the process of removing the High Level Rest Client from the ES codebase. This starts by removing all the HLRC tests themselves so that the other usages can be removed incrementally. Relates to elastic#83423
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
martijnvg
approved these changes
Feb 2, 2022
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM, awesome line delete count!
Contributor
|
I've run into some gotchas backporting stuff due to these tests still existing in older branches. Since the HLRC is "gone" in 8.0+ should we go ahead and backport this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are in the process of removing the High Level Rest Client from the ES codebase. This starts by
removing all the HLRC tests themselves so that the other usages can be removed incrementally.
Relates to #83423