Skip to content

Move Pipeline aggs under VersionedNamedWriteable#83399

Merged
cbuescher merged 2 commits intoelastic:masterfrom
cbuescher:versionedNW-pipelineAggs
Feb 9, 2022
Merged

Move Pipeline aggs under VersionedNamedWriteable#83399
cbuescher merged 2 commits intoelastic:masterfrom
cbuescher:versionedNW-pipelineAggs

Conversation

@cbuescher
Copy link
Copy Markdown
Member

In #81809 we introduced a mechanism to check searializability of search request
to earlier version nodes already on the coordinating node. This requires
knowledge about the version that NamedWritable classes have been introduced,
which is why we started moving classes that are used inside the search request
under the VersionedNamedWriteable interface to make sure future additions
implement the mthod that provides the version information.

This change moves pipeline aggregation builders under that interface. Most builders
have been around long before version 7.0, so we return an empty version tag for them.
The newer ones return the version they were first released in.

@cbuescher cbuescher added :Analytics/Aggregations Aggregations :Search/Search Search-related issues that do not fall into other categories >refactoring labels Feb 2, 2022
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Feb 2, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@cbuescher
Copy link
Copy Markdown
Member Author

@elasticmachine update branch

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@cbuescher
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/part-2

@cbuescher
Copy link
Copy Markdown
Member Author

Thanks a lot @nik9000

@cbuescher cbuescher merged commit d85e70c into elastic:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >refactoring :Search/Search Search-related issues that do not fall into other categories Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants