Handle bounds properly when grid tiles crosses the dateline#83348
Merged
iverase merged 7 commits intoelastic:masterfrom Feb 2, 2022
Merged
Handle bounds properly when grid tiles crosses the dateline#83348iverase merged 7 commits intoelastic:masterfrom
iverase merged 7 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
imotov
approved these changes
Feb 1, 2022
| private boolean validHash(String hash) { | ||
| final Rectangle rectangle = Geohash.toBoundingBox(hash); | ||
| final Rectangle rect = Geohash.toBoundingBox(hash); | ||
| if (rect.getMaxX() < rect.getMinX()) { |
Contributor
There was a problem hiding this comment.
This whole thing could really use a drawing in the comments 😄 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are situation where a grid tile produced by a GeoGridAggregation might cross the dateline. With hex tile is expected but it might happen with geohash as well. In this case, we are not handling properly the tile intersection with the bounds provided by the query.
This PR adds logic to handle those cases in Geohash and Geohex Grid aggregations.
fixes #83299